From 09f35b292242c377689f1d0fb12a904e144d8b93 Mon Sep 17 00:00:00 2001 From: "Collin M. Barrett" Date: Sat, 19 Sep 2020 10:26:12 -0500 Subject: [PATCH] =?UTF-8?q?docs(archival):=20=F0=9F=93=9D=E2=99=BB=20mv=20?= =?UTF-8?q?TODO?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../FilterLists.Archival.Application/Commands/ArchiveList.cs | 1 - .../Persistence/GitFileArchiver.cs | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/services/Archival/FilterLists.Archival.Application/Commands/ArchiveList.cs b/services/Archival/FilterLists.Archival.Application/Commands/ArchiveList.cs index 2602f2236..4e8bc1219 100644 --- a/services/Archival/FilterLists.Archival.Application/Commands/ArchiveList.cs +++ b/services/Archival/FilterLists.Archival.Application/Commands/ArchiveList.cs @@ -97,7 +97,6 @@ private async IAsyncEnumerable GetSegmentsAsync( IEnumerable segmentUrls, [EnumeratorCancellation] CancellationToken cancellationToken) { - // TODO: validate multi-segment lists are archived correctly foreach (var segment in segmentUrls) { var sourceFileName = Uri.UnescapeDataString(segment.Url.Segments.Last()); diff --git a/services/Archival/FilterLists.Archival.Infrastructure/Persistence/GitFileArchiver.cs b/services/Archival/FilterLists.Archival.Infrastructure/Persistence/GitFileArchiver.cs index 58feff7ad..f61d1a3b1 100644 --- a/services/Archival/FilterLists.Archival.Infrastructure/Persistence/GitFileArchiver.cs +++ b/services/Archival/FilterLists.Archival.Infrastructure/Persistence/GitFileArchiver.cs @@ -55,6 +55,8 @@ public async Task ArchiveFileAsync( // TODO: write to _options.RepositoryPath await using var target = file.Target.OpenWrite(); + + // TODO: validate multi-segment lists are archived correctly foreach (var textStream in textStreams) { await textStream.CopyToAsync(target, cancellationToken);