Merge pull request #26 from kkk669/refine-sync2

Refine sync with NEDNSSettingsManager
This commit is contained in:
Kenta Kubo 2020-12-20 20:09:37 +09:00 committed by GitHub
commit 993c03a756
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -46,6 +46,9 @@ struct ContentView {
self.servers.count - 1 - indexSet.count
)
}
if indexSet.map({ self.servers[$0].id.uuidString }).contains(self.usedID) {
self.removeSettings()
}
self.servers.remove(atOffsets: indexSet)
}
@ -55,55 +58,63 @@ struct ContentView {
}
func updateStatus() {
let manager = NEDNSSettingsManager.shared()
manager.loadFromPreferences {
if let err = $0 {
logger.error("\(err.localizedDescription)")
self.alert("Load Error", err.localizedDescription)
} else {
self.isEnabled = manager.isEnabled
#if !targetEnvironment(simulator)
let manager = NEDNSSettingsManager.shared()
manager.loadFromPreferences {
if let err = $0 {
logger.error("\(err.localizedDescription)")
self.alert("Load Error", err.localizedDescription)
} else {
self.isEnabled = manager.isEnabled
}
}
}
#endif
}
func saveSettings() {
let manager = NEDNSSettingsManager.shared()
manager.loadFromPreferences { loadError in
if let loadError = loadError {
logger.error("\(loadError.localizedDescription)")
self.alert("Load Error", loadError.localizedDescription)
return
}
if let usedID = self.usedID,
let uuid = UUID(uuidString: usedID),
let server = self.servers.find(by: uuid) {
manager.dnsSettings = server.configuration.toDNSSettings()
manager.saveToPreferences { saveError in
if let saveError = saveError as NSError? {
guard saveError.domain != "NEConfigurationErrorDomain"
|| saveError.code != 9 else {
return
}
logger.error("\(saveError.localizedDescription)")
self.alert("Save Error", saveError.localizedDescription)
func saveSettings(of server: Resolver) {
if self.usedID != server.id.uuidString {
self.usedID = server.id.uuidString
}
#if !targetEnvironment(simulator)
let manager = NEDNSSettingsManager.shared()
manager.dnsSettings = server.configuration.toDNSSettings()
manager.saveToPreferences { saveError in
if let saveError = saveError as NSError? {
guard saveError.domain != "NEConfigurationErrorDomain"
|| saveError.code != 9 else {
// Nothing was changed
return
}
logger.debug("DNS settings was saved")
}
} else {
guard manager.dnsSettings != nil else {
logger.error("\(saveError.localizedDescription)")
self.alert("Save Error", saveError.localizedDescription)
self.removeSettings()
return
}
manager.removeFromPreferences { removeError in
if let removeError = removeError {
logger.error("\(removeError.localizedDescription)")
self.alert("Remove Error", removeError.localizedDescription)
return
}
logger.debug("DNS settings was removed")
}
logger.debug("DNS settings was saved")
}
}
#endif
}
func removeSettings() {
self.usedID = nil
#if !targetEnvironment(simulator)
let manager = NEDNSSettingsManager.shared()
guard manager.dnsSettings != nil else {
// Already removed
return
}
manager.removeFromPreferences { removeError in
self.updateStatus()
if let removeError = removeError {
logger.error("\(removeError.localizedDescription)")
self.alert("Remove Error", removeError.localizedDescription)
return
}
logger.debug("DNS settings was removed")
}
#endif
}
func alert(_ title: String, _ message: String) {
@ -125,6 +136,11 @@ extension ContentView: View {
get: { server },
set: {
self.servers[i] = $0
let server = self.servers[i]
if server.id.uuidString == self.usedID {
self.saveSettings(of: server)
}
}
),
isOn: .init(
@ -132,7 +148,11 @@ extension ContentView: View {
self.usedID == server.id.uuidString
},
set: {
self.usedID = $0 ? server.id.uuidString : nil
if $0 {
self.saveSettings(of: server)
} else {
self.removeSettings()
}
}
)
),
@ -202,13 +222,9 @@ extension ContentView: View {
}
}
.onChange(of: self.scenePhase) { phase in
#if !targetEnvironment(simulator)
if phase == .active {
self.updateStatus()
} else {
self.saveSettings()
}
#endif
if phase == .active {
self.updateStatus()
}
}
}
}